[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:28
 
-class ObjectFileJITDelegate {
+class ObjectFileDelegate {
 public:
----------------
nit: What about nesting this in the `ObjectFile` class and rename it to `Delegate`. I would be better in term of namespacing IMO


================
Comment at: lldb/source/Expression/CMakeLists.txt:1
-# TODO: Add property `NO_PLUGIN_DEPENDENCIES` to lldbExpression
-add_lldb_library(lldbExpression
+add_lldb_library(lldbExpression NO_PLUGIN_DEPENDENCIES
   DiagnosticManager.cpp
----------------
Nice!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147009/new/

https://reviews.llvm.org/D147009