[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

Mon Mar 27 03:40:29 PDT 2023

labath added a comment.

In D146058#4193594 <https://reviews.llvm.org/D146058#4193594>, @sgraenitz wrote:

>> Pavel runs the x86 debian bot and I think the x86 Windows bot may have been retired, or at least is offline at the moment (https://lab.llvm.org/buildbot/#/builders/83)
>
> Yes, that would be cool. @labath What do you think?

What kind of setup is necessary to make that work? If it's not too complicated, I think we could make something work.

Speaking generally, my only concern with that is the that the bot doesn't remain broken (or even worse -- flaky!) for long stretches of time. I don't have time to debug objc failures, and reverting other people's changes because they break something that might be an "experimental" feature for quite some time could be problematic.

In D146058#4194112 <https://reviews.llvm.org/D146058#4194112>, @sgraenitz wrote:

> My impression was that API tests are LLDB legacy and new tests would usually be Shell. It might still be worth getting (some of) the API tests to work with GNUstep as well, but I might need some advice on how to do that.

The situation is definitely more complicated than that. If you're serious about objc support, I'd definitely recommend getting the existing tests working, as that's the best way to validate correctness and consistency (with the macos runtime). If you're adding some new tests, then they can be shell tests, particularly if they're gnustep-specific.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058