[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 27 03:09:31 PDT 2023


labath added a comment.

In D146590#4220388 <https://reviews.llvm.org/D146590#4220388>, @jgorbe wrote:

> I believe (but I don't have any experience with SWIG typemaps so this is an educated guess) that the call to `free` in the error path comes from the `%typemap(freearg)` immediately after that one. So if freearg already takes care of it, the error handling logic in `%typemap(in)` should just call `SWIG_fail`. Does that sound correct?

Makes sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146590/new/

https://reviews.llvm.org/D146590



More information about the lldb-commits mailing list