[Lldb-commits] [PATCH] D146919: Fix Issue #61706

LU Hongyi via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Mar 26 17:52:19 PDT 2023


jwnhy added a comment.

It seems this is more complicated than I originally thought.
My fix is also flawed when it comes the following program.
Let `overhang_bytes = 0` will overflow the otherside by 1 bit and thus output a wrong value.

But changing everything to signed does not resolve this issue as the following line is a concern.

  m_value.GetScalar() += m_byte_offset; // ValueObjectChild.cpp:181



  #pragma pack(1)
  struct  {
    signed long long f0 : 1;
    unsigned f5 : 32;
  } g_96 = {1, 0xffffffff};
  int main() {return 0;}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146919/new/

https://reviews.llvm.org/D146919



More information about the lldb-commits mailing list