[Lldb-commits] [lldb] 9c6b690 - [lldb] Move #include out of namespace lldb. NFC.

[Benjamin Kramer via lldb-commits]

Author: Benjamin Kramer
Date: 2023-03-25T13:36:49+01:00
New Revision: 9c6b69000d9307a36745004ee9300f70a5415160

URL: https://github.com/llvm/llvm-project/commit/9c6b69000d9307a36745004ee9300f70a5415160
DIFF: https://github.com/llvm/llvm-project/commit/9c6b69000d9307a36745004ee9300f70a5415160.diff

LOG: [lldb] Move #include out of namespace lldb. NFC.

Including system headers in a namespace is not safe.

Added: 
    

Modified: 
    lldb/include/lldb/lldb-types.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/lldb-types.h b/lldb/include/lldb/lldb-types.h
index 890b513cd6ee8..f38095ffebd89 100644
--- a/lldb/include/lldb/lldb-types.h
+++ b/lldb/include/lldb/lldb-types.h
@@ -33,11 +33,11 @@
 //  LLDB_INVALID_HOST_THREAD  The value of an invalid lldb::thread_t
 //  LLDB_INVALID_PIPE         The value of an invalid lldb::pipe_t
 
-namespace lldb {
-
 #ifdef _WIN32
 
 #include <process.h>
+
+namespace lldb {
 typedef void *rwlock_t;
 typedef void *process_t;                          // Process type is HANDLE
 typedef void *thread_t;                           // Host thread type
@@ -51,6 +51,8 @@ typedef void *pipe_t;                             // Host pipe type is HANDLE
 #else
 
 #include <pthread.h>
+
+namespace lldb {
 typedef pthread_rwlock_t rwlock_t;
 typedef uint64_t process_t;             // Process type is just a pid.
 typedef pthread_t thread_t;             // Host thread type