[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

Nico Weber via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Mar 25 00:55:03 PDT 2023


thakis added a comment.

Hello, https://github.com/llvm/llvm-project/commit/5fb4147f74ad90095f08f243e5f19877d09d11b9 broke the windows build (http://45.33.8.238/win/76494/step_4.txt) because it's now including system headers within namespace lldb. Please take a look and revert for now if it takes a while to fix.

(Saying that here since I see no phab link on the bad commit. Uploading changes to phab gives you access to pre-commit testing on a bunch of platforms, so it's useful even for post-commit reviewed patches)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146668/new/

https://reviews.llvm.org/D146668



More information about the lldb-commits mailing list