[Lldb-commits] [lldb] d0acc6f - [lldb][NFC] Remove outdated TODOs from API headers

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 24 15:51:19 PDT 2023


Author: Alex Langford
Date: 2023-03-24T15:50:57-07:00
New Revision: d0acc6f8c285a47eadc703385861c570f8a84978

URL: https://github.com/llvm/llvm-project/commit/d0acc6f8c285a47eadc703385861c570f8a84978
DIFF: https://github.com/llvm/llvm-project/commit/d0acc6f8c285a47eadc703385861c570f8a84978.diff

LOG: [lldb][NFC] Remove outdated TODOs from API headers

There were added when I removed the swig interface files in
662548c82683bd8657a3179afee693c4965a3dfd. However, they mostly meant for
me to better track the differences between the existing API headers and
bindings interfaces. There's nothing actionable about these so I remove
them.

Added: 
    

Modified: 
    lldb/include/lldb/API/SBListener.h
    lldb/include/lldb/API/SBProcess.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/API/SBListener.h b/lldb/include/lldb/API/SBListener.h
index fe631bb86defd..eaa8b59d0c49b 100644
--- a/lldb/include/lldb/API/SBListener.h
+++ b/lldb/include/lldb/API/SBListener.h
@@ -37,7 +37,6 @@ class LLDB_API SBListener {
                                        const char *broadcaster_class,
                                        uint32_t event_mask);
 
-  // TODO: This returns uint32_t in the interface files. :/
   bool StopListeningForEventClass(SBDebugger &debugger,
                                   const char *broadcaster_class,
                                   uint32_t event_mask);

diff  --git a/lldb/include/lldb/API/SBProcess.h b/lldb/include/lldb/API/SBProcess.h
index be0048763a25d..b7eb2036dbe47 100644
--- a/lldb/include/lldb/API/SBProcess.h
+++ b/lldb/include/lldb/API/SBProcess.h
@@ -115,7 +115,6 @@ class LLDB_API SBProcess {
   // Queue related functions
   uint32_t GetNumQueues();
 
-  // TODO: This technically takes a uint32_t in the interface file.
   lldb::SBQueue GetQueueAtIndex(size_t index);
 
   // Stepping related functions


        


More information about the lldb-commits mailing list