[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

[Jorge Gorbe Moya via Phabricator via lldb-commits]

jgorbe added a comment.

By the way, I just bisected another problem to this commit: I'm seeing in some cases that prettyprinted values with synthetic children don't show child names when using `dwim-print`. So print used to show:

  (lldb) p c
  (MyClass) $0 = MyClass object with children: {
    [0] = 0x0000555555556004 "hello"
  }
  (lldb) p m
  (MyMap) $1 = MyMap object with children: {
    ["my_key"] = 0x0000555555556011 "my_value"
  }

but now it shows

  (lldb) p c
  (MyClass)  MyClass object with children: {
    0x0000555555556004 "hello"
  }
  (lldb) p m
  (MyMap)  MyMap object with children: {
    0x0000555555556011 "my_value"
  }

I don't have a repro test case to share right away but I though I'd give you a heads-up in case the problem is easy to find from the description. Or maybe it's the intended behavior? I get the same behavior with `expr --persistent-result off -- m` so I can't tell if it's a bug or if it's just the expected behavior when disabling persistent results. If it's the latter, that's a strong argument for me to unalias `print` and restore the old behavior in the lldbinit file we ship to our internal users.

I'll work on a small shareable test case tomorrow anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145609/new/

https://reviews.llvm.org/D145609