[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

[Alexander Yermolovich via Phabricator via lldb-commits]

ayermolo added inline comments.


================
Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11
+# CHECK: 0x0000006e: adding range [0x0000000000000000-0x000000000000001f)
+# CHECK-SAME: which has a base that is less than the function's low PC 0x0000000000000021.
+# CHECK-SAME: Please file a bug and attach the file at the start of this error message
----------------
clayborg wrote:
> clayborg wrote:
> > Shouldn't the low PC of the function be zero?
> ```
> 0x00000043:   DW_TAG_subprogram
>                 DW_AT_low_pc	(0x0000000000000001)
>                 DW_AT_high_pc	(0x000000000000002e)
>                 DW_AT_frame_base	(DW_OP_reg6 RBP)
>                 DW_AT_linkage_name	("_ZL3foob")
>                 DW_AT_name	("foo")
>                 DW_AT_decl_file	("base-lower-then-range-entry/base-lower-then-range-entry/main.cpp")
>                 DW_AT_decl_line	(1)
>                 DW_AT_type	(0x0000008b)
> 
> 0x00000060:     DW_TAG_formal_parameter
>                   DW_AT_location	(DW_OP_fbreg -5)
>                   DW_AT_name	("b")
>                   DW_AT_decl_file	("base-lower-then-range-entry/base-lower-then-range-entry/main.cpp")
>                   DW_AT_decl_line	(1)
>                   DW_AT_type	(0x00000092)
> 
> 0x0000006e:     DW_TAG_lexical_block
>                   DW_AT_ranges	(0x00000000
>                      [0x0000000000000000, 0x000000000000001f)
>                      [0x0000000000000000, 0x000000000000002d))
> ```
> 
> Seems like we have a bug in the code that prints the error message?
Stepped through the code 0x21 is what gets extracted in DWARFDebugInfoEntry::GetDIENamesAndRanges.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146659/new/

https://reviews.llvm.org/D146659