[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

David Blaikie via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 23 11:09:40 PDT 2023


dblaikie added a comment.

> The rationale is: dwim-print doesn't always use expression evaluation, it prefers to use frame variable where possible. In the future it could be expanded, for example to print register as well. Because dwim-print doesn't always use expression, there isn't always a persistent result.

Oh, so in the cases where `dwim-print` delegates to `frame variable` you can't then refer to that result in another `dwim-print` command/other place where you'd like to reference a previously printed value?

That seems like a significant regression over existing print functionality and compared to gdb. At least for me that'd be annoying/inconvenient to have to think about which kind of printing I'm doing (& have to explicitly use the less stable full expression based printing) when I want to reuse a value.

> To make dwim-print output consistent, and because it's presumed most users don't use persistent results

Got data on that? I'd /guess/ I use it maybe in single digit % of my prints, but probably at least 1%, though no idea if that's representative - even if it is, the inconsistency feels counter to the goals of dwim-print & the convenience provided by gdb's consistent value handling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145609/new/

https://reviews.llvm.org/D145609



More information about the lldb-commits mailing list