[Lldb-commits] [PATCH] D146548: [lldb] Refactor deduction of the instance variable's name (NFC)
Dave Lee via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 21 10:49:51 PDT 2023
kastiglione created this revision.
kastiglione added a reviewer: aprantl.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Move responsibility of providing the instance variable name (`this`, `self`) from
`TypeSystem` to `Language`.
`Language` the natural place for this, but also has downstream benefits. Some languages
have multiple `TypeSystem` implementations (ex Swift), and by placing this logic in the
`Language`, redundancy is avoided.
This change relies on the tests from D145348 <https://reviews.llvm.org/D145348> and D146320 <https://reviews.llvm.org/D146320>.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D146548
Files:
lldb/include/lldb/Symbol/CompilerDeclContext.h
lldb/include/lldb/Symbol/TypeSystem.h
lldb/include/lldb/Target/Language.h
lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h
lldb/source/Plugins/Language/ObjC/ObjCLanguage.h
lldb/source/Plugins/Language/ObjCPlusPlus/ObjCPlusPlusLanguage.h
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h
lldb/source/Symbol/CompilerDeclContext.cpp
lldb/source/Symbol/SymbolContext.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146548.507051.patch
Type: text/x-patch
Size: 6934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230321/c5f91ede/attachment.bin>
More information about the lldb-commits
mailing list