[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz created this revision.
sgraenitz added reviewers: teemperor, bulbazord, JDevlieghere.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
sgraenitz requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: LLDB.

I came accross this, because a lot of regression tests were saying:

  (lldb) p argc
  error: expression failed to parse:
  error: couldn't install checkers, unknown error

With this change, error messages provide more detail:

  (lldb) p argc
  error: expression failed to parse:
  error: couldn't install checkers:
  error: Couldn't lookup symbols:
    __objc_load

I didn't find a case where `Diagnostics()` is not empty. Also it looks like this isn't covered in any test (yet).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146541

Files:
  lldb/include/lldb/Expression/DynamicCheckerFunctions.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.cpp
  lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146541.507020.patch
Type: text/x-patch
Size: 5285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230321/a5c6b9b6/attachment.bin>