[Lldb-commits] [lldb] c1e4a0d - Follow on to 2c7abc83f605b2d3b1062f28422eeff81278ecd5.

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 20 16:49:14 PDT 2023


Author: Jim Ingham
Date: 2023-03-20T16:49:05-07:00
New Revision: c1e4a0d4dbe9d68113a877764c794407bdd65622

URL: https://github.com/llvm/llvm-project/commit/c1e4a0d4dbe9d68113a877764c794407bdd65622
DIFF: https://github.com/llvm/llvm-project/commit/c1e4a0d4dbe9d68113a877764c794407bdd65622.diff

LOG: Follow on to 2c7abc83f605b2d3b1062f28422eeff81278ecd5.

I didn't refactor the test that's failing on arm64 correctly so it
failed everywhere.

Looks like the step test passes on other aarch64 systems as well as
Darwin.  Turn off the xfail and see how far that gets.

Added: 
    

Modified: 
    lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py b/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py
index 52fc899b13e61..fd70bd692a216 100644
--- a/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py
+++ b/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py
@@ -36,12 +36,6 @@ def get_to_start(self, bkpt_text):
         
         return (target, process, thread, read_watchpoint)
     
-    @expectedFailureAll(
-        oslist=["freebsd", "linux"],
-        archs=[
-            'aarch64',
-            'arm'],
-        bugnumber="llvm.org/pr26031")
     # Read-write watchpoints not supported on SystemZ
     @expectedFailureAll(archs=['s390x'])
     @add_test_categories(["basic_process"])
@@ -69,8 +63,6 @@ def test_step_over(self):
     def test_step_instruction(self):
         target, process, thread, wp = self.get_to_start("Set breakpoint after call")
 
-        self.assertEquals(thread.GetStopDescription(20), 'step over')
-
         self.step_inst_for_watchpoint(1)
 
         write_value = frame.FindValue('g_watch_me_write',


        


More information about the lldb-commits mailing list