[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Mon Mar 20 07:08:53 PDT 2023

erichkeane added a subscriber: asl.
erichkeane added a comment.

I've got the 1 concern with the mangling that I REALLY want one of our codegen owners to chime in on, otherwise this LGTM.

================
Comment at: clang/lib/AST/ItaniumMangle.cpp:4397
+    // argument.
+    // As proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/111.
+    auto *SNTTPE = cast<SubstNonTypeTemplateParmExpr>(E);
----------------
erichkeane wrote:
> aaron.ballman wrote:
> > We should get this nailed down. It was proposed in Nov 2020 and the issue is still open. CC @rjmccall 
> This definitely needs to happen.  @rjmccall or @eli.friedman ^^ Any idea what the actual mangling should be?
This is still an open, and we need @rjmccall @eli.friedman or @asl to help out here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140996/new/

https://reviews.llvm.org/D140996