[Lldb-commits] [lldb] 60a7188 - [lldb][test] TestInlineNamespaceAlias.py: skip on older compiler versions

[Michael Buch via lldb-commits]

Author: Michael Buch
Date: 2023-03-10T12:20:58Z
New Revision: 60a7188cb086abe172bc46582356f30b3c3e1c4c

URL: https://github.com/llvm/llvm-project/commit/60a7188cb086abe172bc46582356f30b3c3e1c4c
DIFF: https://github.com/llvm/llvm-project/commit/60a7188cb086abe172bc46582356f30b3c3e1c4c.diff

LOG: [lldb][test] TestInlineNamespaceAlias.py: skip on older compiler versions

This was failing with versions of clang that didn't support the
dsymutil (D143458) and llvm (D143397) changes that are needed for this test.

Remove unused parameters that we tried passing for the `dwarf` variant, which
is an NFC change. LLDB doesn't yet support `-gdwarf-5` debugging yet so
passing it to the `Makefile` would actually cause the test to fail.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py b/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py
index 0c3f3d457f254..5220a6e0099cd 100644
--- a/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py
+++ b/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py
@@ -11,7 +11,8 @@
 from lldbsuite.test import lldbutil
 
 class TestInlineNamespace(TestBase):
-    def do_test(self, params):
+    @skipIf(compiler="clang", compiler_version=['<', '16.0'])
+    def test(self):
         self.build()
 
         lldbutil.run_to_source_breakpoint(self,
@@ -27,11 +28,3 @@ def do_test(self, params):
         self.expect_expr("E::D::a", result_type="int", result_value="-1")
         self.expect_expr("F::a", result_type="int", result_value="-1")
         self.expect_expr("G::a", result_type="int", result_value="-1")
-
-    @skipIf(debug_info=no_match(["dsym"]))
-    def test_dsym(self):
-        self.do_test({})
-
-    @skipIf(debug_info="dsym")
-    def test_dwarf(self):
-        self.do_test(dict(CFLAGS_EXTRAS="-gdwarf-5 -gpubnames"))