[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

Thu Mar 9 14:57:57 PST 2023

bulbazord marked 11 inline comments as done.
bulbazord added inline comments.

================
Comment at: lldb/source/Target/Memory.cpp:255-256

-      // We need to read from the process
+      if (process_bytes_read < cache_line_byte_size)
+        data_buffer_heap_up->SetByteSize(process_bytes_read);

----------------
bulbazord wrote:
> clayborg wrote:
> > If we don't read an entire cache line, should we populate this into the L1 cache instead? It might make the logic for accessing data in the L2 cache a bit simpler?
> That might not be a bad idea actually. I'll try it and see how much it simplifies the logic.
It didn't make things any simpler so I didn't change it. Good idea though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145624/new/

https://reviews.llvm.org/D145624