[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

Michael Buch via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 8 16:54:13 PST 2023


Michael137 added a comment.

In D145569#4179648 <https://reviews.llvm.org/D145569#4179648>, @jingham wrote:

> The TSAN instrumenter has the same `struct data` definition.  I actually got a report of this crashing in TSAN yesterday.  You should do that one as well.  Otherwise, LGTM and I don't think you need to add a test with "struct data" in it on the off chance that someone reverts this back to exactly `struct data`...

Ah good point, done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145569/new/

https://reviews.llvm.org/D145569



More information about the lldb-commits mailing list