[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 503497.
jasonmolenda added a comment.

Show an alternate approach, where we check the file types of everything in the kernel+kext list, and if something is not a kernel/kext, don't try to load it at all.  v. the first change in `DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule` where I call `!IsKernel() && !obj_macho->IsKext()` to detect something in the list which isn't processed the standard way that kexts & the kernel are.  Either one would work in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145547/new/

https://reviews.llvm.org/D145547

Files:
  lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt
  lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145547.503497.patch
Type: text/x-patch
Size: 6813 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230308/a9079800/attachment-0001.bin>