[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

[Thorsten via Phabricator via lldb-commits]

tschuett added inline comments.


================
Comment at: lldb/include/lldb/Target/RegisterFlags.h:20
+  public:
+    Field(const std::string &name, unsigned start, unsigned end,
+          const std::string &type)
----------------
There are a lot of `const std::string& ` . Are you allowed to use `llvm::StringRef` or even `std::string_view` in LLDB?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145566/new/

https://reviews.llvm.org/D145566