[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

Wed Mar 8 01:29:54 PST 2023

DavidSpickett added a comment.

Seems to me that member functions of `ELFRelocation` should use the typedefs from `lldb/source/Plugins/ObjectFile/ELF/ELFHeader.h` where there is one. `elf_sxword` for example.

If you want to do that in another patch, that's fine. Just in case some test case is relying on the uin64_t -> unsigned down cast unintentionally.

================
Comment at: lldb/test/Shell/ObjectFile/ELF/loongarch64-relocations.yaml:37
         Type:            R_LARCH_64
-        Addend:          0x5678
+        Addend:          0x1122334455667788
 Symbols:
----------------
I'm not familiar with how these relocation are processed, would it be better to use something with the sign bit set here? Or does it not matter, the value is just copied into .debug_info verbatim anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145550/new/

https://reviews.llvm.org/D145550