[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: lldb/include/lldb/Core/Debugger.h:563
+  // the previous IOHandler thread.
+  const HostThread SetIOHandlerThread(HostThread &new_thread);
 
----------------
labath wrote:
> `const` on a return value rarely makes sense. OTOH, `const` on the argument usually does. Did you want this the other way around?
Neither of these is really const.  The incoming thread will get set to be the IOHandler for the debugger which is not really const.  Not sure what I was thinking here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145136/new/

https://reviews.llvm.org/D145136