[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this
Dave Lee via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 7 11:42:41 PST 2023
kastiglione added inline comments.
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818
+ if (ClangASTMetadata *metadata = GetMetadata(fun_decl))
+ return metadata->GetObjectPtrLanguage();
+ }
----------------
aprantl wrote:
> Couple of questions for my understanding:
>
> 1. Do you see any opportunities for this to spectacularly do the wrong thing in an ObjectiveC++ program by guessing the wrong language? I suppose this just tries to do a best effort?
>
> 2. We're not using the DW_AT_APPLE_runtime_language attribute because it's only attached to Objective-C classes?
>
> 3. We're not using the DW_AT_language of the DW_TAG_compile_unit because it won't help us in an ObjC++ program?
> We're not using the `DW_AT_APPLE_runtime_language` attribute because it's only attached to Objective-C classes?
> We're not using the `DW_AT_language` of the `DW_TAG_compile_unit` because it won't help us in an ObjC++ program?
I am not sure how to answer these too. While this function is new, the logic and this code path which calls `GetObjectPtrLanguage`, is taken from the existing implementation. In other words, how the debug info is made use of, hasn't changed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145276/new/
https://reviews.llvm.org/D145276
More information about the lldb-commits
mailing list