[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

[Dave Lee via Phabricator via lldb-commits]

kastiglione updated this revision to Diff 503105.
kastiglione added a comment.

Fix adjacent code and make the tests pass


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145437/new/

https://reviews.llvm.org/D145437

Files:
  lldb/tools/lldb-vscode/lldb-vscode.cpp


Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -1065,8 +1065,9 @@
     text = text.substr(1);
     actual_column--;
   } else {
-    text = "p " + text;
-    actual_column += 2;
+    char command[] = "expression -- ";
+    text = command + text;
+    actual_column += strlen(command);
   }
   lldb::SBStringList matches;
   lldb::SBStringList descriptions;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145437.503105.patch
Type: text/x-patch
Size: 513 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230307/88a014f3/attachment.bin>