[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py:301
+            "frame variable virt_member_func_ptr",
+            patterns=['virt_member_func_ptr = ([0-9]{2}\s)+01'])
----------------
labath wrote:
> If [[ https://godbolt.org/z/x1Yjs83ca | this ]] godbolt is right, then this won't work. Encoding of member pointers is abi-dependant, and it seems that MSVC encodes them as regular pointers to thunk functions (instead of these fancy tagged unions).
> 
> Come to think of it... I'm not sure why everyone doesn't do it that way...
Ah good point. Testing this here in this patch isn't necessary anyway. I'll add it back in the follow-up patches


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145487/new/

https://reviews.llvm.org/D145487