[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

Tue Mar 7 02:08:09 PST 2023

DavidSpickett added a comment.

I see from `/usr/include/elf.h` on my system that the numbers do restart for each architecture. We got away with it for the set of relocations we were looking at. I like the new structure, it is clearer especially for the signed checks.

I presume the definitions for the relocations actually come from `llvm/include/llvm/BinaryFormat/ELFRelocs/LoongArch.def`, so this will build fine with a toolchain that doesn't know about LoongArch yet.

================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2623
+        (is_signed &&
+         ((int64_t)value > INT32_MAX && (int64_t)value < INT32_MIN))) {
+      Log *log = GetLog(LLDBLog::Modules);
----------------
Should this be `||` not `&&`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145462/new/

https://reviews.llvm.org/D145462