[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

Mon Mar 6 17:12:37 PST 2023

stella.stamenova added a comment.

In D145242#4173592 <https://reviews.llvm.org/D145242#4173592>, @Michael137 wrote:

> In D145242#4173577 <https://reviews.llvm.org/D145242#4173577>, @stella.stamenova wrote:
>
>> Looks like either this change or D125241 <https://reviews.llvm.org/D125241> broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and revert the changes to bring it back to green.
>
> Ah thanks for pointing it out. Thought I had fixed it with https://reviews.llvm.org/rG96e39fdbb90b26191fc79b6226f299e3c10e559b
>
> Will check on my Windows machine. But feel free to revert, since I'm only going to be able to look at it tomorrow

The lldb bot I pointed you is not an arm buildbot, it's x64. Also the test you fixed is `ast-types`, but there were actually two failing tests - `TestDataFormatterCpp.py` is still failing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145242/new/

https://reviews.llvm.org/D145242