[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

[Dave Lee via Phabricator via lldb-commits]

kastiglione created this revision.
kastiglione added a reviewer: aprantl.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Change lldb-vscode to use the `expression` command for generating completions, instead
of the `p` alias.

Aliases are user overrideable, and even deletable, but the `expression` command is
unchangeable.

See D141539 <https://reviews.llvm.org/D141539> where a similar replacement was done to tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145437

Files:
  lldb/tools/lldb-vscode/lldb-vscode.cpp


Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -1065,7 +1065,7 @@
     text = text.substr(1);
     actual_column--;
   } else {
-    text = "p " + text;
+    text = "expression -- " + text;
     actual_column += 2;
   }
   lldb::SBStringList matches;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145437.502824.patch
Type: text/x-patch
Size: 407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230306/f60bbffc/attachment.bin>