[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

Mon Mar 6 05:43:36 PST 2023

labath added inline comments.

================
Comment at: lldb/source/Utility/ProcessInfo.cpp:11

+#include "lldb/Interpreter/ScriptedMetadata.h"
 #include "lldb/Utility/ArchSpec.h"
----------------
This is a layering violation. Can we restructure this so that it this does not depend on code outside the Utility library? Maybe the ScriptedMetadata thingy could be moved into the Utility library?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143104/new/

https://reviews.llvm.org/D143104