[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/include/lldb/Core/Debugger.h:397-398
+  /// cooperative interruption.  If this is non-zero, InterruptRequested will
+  /// return true.  Interruptible operations are expected to query this
+  /// flag periodically, and interrupt what they were doing if it is true.
+  ///
----------------



================
Comment at: lldb/include/lldb/Core/Debugger.h:405
+  
+  /// Decrement the "interrupt requested" flag.  This is queried by
+  /// InterruptRequested, and any interruptible operations will be interrupted
----------------
Saying "Decrement the interrupt requested _flag_" seems weird. Is this a flag or an interrupt count? Maybe saying "Decrement the interrupt request count of non zero" might be a bit more clear?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145136/new/

https://reviews.llvm.org/D145136