[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

[Heejin Ahn via Phabricator via lldb-commits]

aheejin created this revision.
aheejin added reviewers: jingham, JDevlieghere.
Herald added a subscriber: wingo.
Herald added a project: All.
aheejin requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This reverts commit e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73 <https://reviews.llvm.org/rGe12a950d90f88aeddaa97d6e7c8fd0bfedc42f73>.

D142241 <https://reviews.llvm.org/D142241> broke `-sBUILD_SHARED_LIBS=ON` build. I commented on that CL
about this issue, and also asked the same question on the LLVM discourse
(https://discourse.llvm.org/t/build-shared-libs-on-doesnt-work-with-lldb-instr/68793),
but neither was answered.

As I asked on the post, it looks the CL description says having
CLANG_LIBS and LINK_COMPONENTS Support within a single file is a
problem, but there are many files in lldb that use both, so I don't
understand what was the issue:

  ./lldb/source/Core/CMakeLists.txt
  ./lldb/source/Plugins/TypeSystem/Clang/CMakeLists.txt
  ./lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt
  ./lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/CMakeLists.txt
  ./lldb/source/Plugins/ExpressionParser/Clang/CMakeLists.txt
  ./lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt
  ./lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt
  ./lldb/source/Plugins/SymbolFile/NativePDB/CMakeLists.txt
  ./lldb/source/Plugins/SymbolFile/PDB/CMakeLists.txt

I'd hope to at least get the answers why D142241 <https://reviews.llvm.org/D142241> was necessary this
time.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145181

Files:
  lldb/tools/lldb-instr/CMakeLists.txt


Index: lldb/tools/lldb-instr/CMakeLists.txt
===================================================================
--- lldb/tools/lldb-instr/CMakeLists.txt
+++ lldb/tools/lldb-instr/CMakeLists.txt
@@ -11,4 +11,6 @@
     clangSerialization
     clangTooling
 
+  LINK_COMPONENTS
+    Support
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145181.501958.patch
Type: text/x-patch
Size: 293 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230302/158011a8/attachment.bin>