[Lldb-commits] [lldb] b970e72 - Revert "[lldb/Interpreter] Fix build failures in ScriptInterpreterLua"

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 2 12:46:47 PST 2023


Author: Med Ismail Bennani
Date: 2023-03-02T12:46:18-08:00
New Revision: b970e725d8fd3f9b3d587e5203efd5e6f2e84e9a

URL: https://github.com/llvm/llvm-project/commit/b970e725d8fd3f9b3d587e5203efd5e6f2e84e9a
DIFF: https://github.com/llvm/llvm-project/commit/b970e725d8fd3f9b3d587e5203efd5e6f2e84e9a.diff

LOG: Revert "[lldb/Interpreter] Fix build failures in ScriptInterpreterLua"

This reverts commit 6de18eb050a66544cc38210024860366b84faf35.

Added: 
    

Modified: 
    lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp
    lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp b/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp
index bbdda3284c193..ec0992583145e 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp
+++ b/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp
@@ -111,7 +111,7 @@ class IOHandlerLuaInterpreter : public IOHandlerDelegate,
               io_handler.GetUserData());
       for (BreakpointOptions &bp_options : *bp_options_vec) {
         Status error = m_script_interpreter.SetBreakpointCommandCallback(
-            bp_options, data.c_str(), /*is_callback=*/false);
+            bp_options, data.c_str());
         if (error.Fail())
           *io_handler.GetErrorStreamFileSP() << error.AsCString() << '\n';
       }
@@ -121,8 +121,7 @@ class IOHandlerLuaInterpreter : public IOHandlerDelegate,
       auto *wp_options =
           static_cast<WatchpointOptions *>(io_handler.GetUserData());
       m_script_interpreter.SetWatchpointCommandCallback(wp_options,
-                                                        data.c_str(),
-                                                        /*is_callback=*/false);
+                                                        data.c_str());
       io_handler.SetIsDone(true);
     } break;
     case eIOHandlerNone:
@@ -349,7 +348,7 @@ Status ScriptInterpreterLua::SetBreakpointCommandCallbackFunction(
 }
 
 Status ScriptInterpreterLua::SetBreakpointCommandCallback(
-    BreakpointOptions &bp_options, const char *command_body_text, bool is_callback) {
+    BreakpointOptions &bp_options, const char *command_body_text) {
   return RegisterBreakpointCallback(bp_options, command_body_text, {});
 }
 
@@ -369,7 +368,7 @@ Status ScriptInterpreterLua::RegisterBreakpointCallback(
 }
 
 void ScriptInterpreterLua::SetWatchpointCommandCallback(
-    WatchpointOptions *wp_options, const char *command_body_text, bool is_callback) {
+    WatchpointOptions *wp_options, const char *command_body_text) {
   RegisterWatchpointCallback(wp_options, command_body_text, {});
 }
 

diff  --git a/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h b/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h
index ca14e189acd84..3f9f42c0c3b6e 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h
+++ b/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h
@@ -92,8 +92,7 @@ class ScriptInterpreterLua : public ScriptInterpreter {
                                       bool is_callback) override;
 
   void SetWatchpointCommandCallback(WatchpointOptions *wp_options,
-                                    const char *command_body_text,
-                                    bool is_callback) override;
+                                    const char *command_body_text) override;
 
   Status SetBreakpointCommandCallbackFunction(
       BreakpointOptions &bp_options, const char *function_name,


        


More information about the lldb-commits mailing list