[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D144688#4165152 <https://reviews.llvm.org/D144688#4165152>, @delcypher wrote:

> In D144688#4165144 <https://reviews.llvm.org/D144688#4165144>, @kparzysz wrote:
>
>> This broke Lua support:
>>
>>   In file included from /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:9:
>>   /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h:95:68: error: non-virtual member function marked 'override' hides virtual member function
>>                                       const char *command_body_text) override;
>>                                                                      ^
>>   /w/src/llvm.org/lldb/include/lldb/Interpreter/ScriptInterpreter.h:415:16: note: hidden overloaded virtual function 'lldb_private::ScriptInterpreter::SetWatchpointCommandCallback' declared here: different number of parameters (3 vs 2)
>>     virtual void SetWatchpointCommandCallback(WatchpointOptions *wp_options,
>>                  ^
>
> @mib 👆

Yup, saw that. We don't have any bot that tests LUA so this went unnoticed ... I'm rebuilding lldb now with lua, will come up with a fix in a few :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144688/new/

https://reviews.llvm.org/D144688