[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with two small nits.



================
Comment at: lldb/include/lldb/API/SBWatchpoint.h:14
+#include "lldb/API/SBType.h"
+#include <string>
 
----------------
No longer necessary?


================
Comment at: lldb/include/lldb/lldb-enumerations.h:1224-1228
+  eWatchPointValueKindVariable =
+      1, ///< watchpoint was created watching a variable
+  eWatchPointValueKindExpression =
+      2, ///< watchpoint was created watching the result of an expression that
+         ///< was evaluated at creation time.
----------------
With the 80-col limit it helps readability to put the Doxygen comments on the line above. Also comments should start with a capital. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144937/new/

https://reviews.llvm.org/D144937