[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

[Dan Liew via Phabricator via lldb-commits]

delcypher added a comment.

In D144937#4159324 <https://reviews.llvm.org/D144937#4159324>, @jasonmolenda wrote:

> Hi Dan, I hadn't looked this over very closely but one thing that jumped out is that you're adding a member to SBWatchpoint, and we can't do that, it's an API breaking change.  In cases where we need to store additional information than a weak pointer to an lldb private object, we traditionally add an Impl class which has the additional member(s) and a shared pointer to the lldb private object that backs the class.  e.g. see SBValue's ValueImpl, the definition is in SBValue.cpp.

I talked to @jasonmolenda offline about this. He meant ABI (broken by the patch in its current form) not API (not broken by this patch in its current form).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144937/new/

https://reviews.llvm.org/D144937