[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316
+    auto_generated_function.AppendString("    def __user_code():");
+    for (int i = 0; i < num_lines; ++i) {
+      sstr.Clear();
----------------
bulbazord wrote:
> delcypher wrote:
> > Why do we need to loop over multiple lines in this is a "oneliner"?
> > 
> > Is `num_lines == 1` equivalent to `is_oneliner`?
> > 
> > 
> > If yes, then the `is_oneliner` parameter is not needed.
> > If no, then `is_oneliner` should probably be renamed to make sure this confusion cannot be made.
> +1
You can do:

(lldb) breakpoint command add -s python -o "first_python_line" -o "second_python_line"

which give you a "one-line" command with two lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144688/new/

https://reviews.llvm.org/D144688