[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

IIUC, not removing elements from the internal dict will mean cross-contamination between the python states when you have multiple concurrent debuggers, which for instance Xcode does a lot.  New variables would appear in the other session, but not linked to this debugger.  That could cause subtle problems, which it's worth doing some extra work to avoid.

We should also make sure in the test that a watchpoint command that returns nothing still works.  That's suppose to be the equivalent of returning True.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144688/new/

https://reviews.llvm.org/D144688