[Lldb-commits] [PATCH] D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 23 12:09:28 PST 2023


jingham created this revision.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

In the auto-continue after we stop at the start point when running the debugger asynchronously, we use PrivateResume to continue.  But that doesn't update the stop locker state, which is currently at "stopped".  That means the stop locker wasn't doing its job to prevent you from running expressions while the target is running.

I fixed this, and added a test for this case to make sure we get a proper error back.  This patch requires (and adds the test for):

https://reviews.llvm.org/D144664


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144665

Files:
  lldb/source/API/SBFrame.cpp
  lldb/source/API/SBTarget.cpp
  lldb/source/Target/Target.cpp
  lldb/test/API/python_api/run_locker/Makefile
  lldb/test/API/python_api/run_locker/TestRunLocker.py
  lldb/test/API/python_api/run_locker/main.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144665.499943.patch
Type: text/x-patch
Size: 8896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230223/b70cdf61/attachment-0001.bin>


More information about the lldb-commits mailing list