[Lldb-commits] [lldb] bd56c8d - [lldb] Skip test_stop_reply_contains_thread_pcs on Windows

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 23 08:10:16 PST 2023


Author: David Spickett
Date: 2023-02-23T16:08:44Z
New Revision: bd56c8d5f59a22b6c0ab64328b87d831a0c4468c

URL: https://github.com/llvm/llvm-project/commit/bd56c8d5f59a22b6c0ab64328b87d831a0c4468c
DIFF: https://github.com/llvm/llvm-project/commit/bd56c8d5f59a22b6c0ab64328b87d831a0c4468c.diff

LOG: [lldb] Skip test_stop_reply_contains_thread_pcs on Windows

I marked this as expected to fail, but it doesn't always fail,
and an unexpected success is a failure.

Skip it instead.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
index e8805a68d33a..c81bd34c2f6c 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
@@ -171,7 +171,7 @@ def test_stop_reply_reports_correct_threads(self):
             self.assertIn(tid, stop_reply_threads)
 
     @skipIfNetBSD
-    @expectedFailureAll(oslist=["windows"]) # Extra threads present
+    @skipIfWindows # Flaky on Windows
     def test_stop_reply_contains_thread_pcs(self):
         self.build()
         self.set_inferior_startup_launch()


        


More information about the lldb-commits mailing list