[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

Anton Sidorenko via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 10 04:39:17 PST 2023


asi-sc created this revision.
Herald added a project: All.
asi-sc requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

YAML specification does not allow keys duplication an a mapping. However, YAML
parser in LLVM does not have any check on that and uses only the last key entry.
In this change duplicated keys are merged to satisfy the spec.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143727

Files:
  lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
  lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
  lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml


Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
===================================================================
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
@@ -5,7 +5,6 @@
   Type:            ET_DYN
   Machine:         EM_ARM
   Flags:           [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:            .text
     Type:            SHT_PROGBITS
Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
===================================================================
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
@@ -5,7 +5,6 @@
   Type:            ET_DYN
   Machine:         EM_ARM
   Flags:           [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:            .text
     Type:            SHT_PROGBITS
Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
===================================================================
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
@@ -8,7 +8,6 @@
   Type:            ET_DYN
   Machine:         EM_ARM
   Flags:           [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:            .text
     Type:            SHT_PROGBITS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143727.496428.patch
Type: text/x-patch
Size: 1578 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230210/03b272e2/attachment.bin>


More information about the lldb-commits mailing list