[Lldb-commits] [lldb] 785009e - [lldb][test] Fix function references to function calls (NFC)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 8 12:12:44 PST 2023


Author: Dave Lee
Date: 2023-02-08T12:12:33-08:00
New Revision: 785009e19fbcbeaca206f7e5a786cb034a374e19

URL: https://github.com/llvm/llvm-project/commit/785009e19fbcbeaca206f7e5a786cb034a374e19
DIFF: https://github.com/llvm/llvm-project/commit/785009e19fbcbeaca206f7e5a786cb034a374e19.diff

LOG: [lldb][test] Fix function references to function calls (NFC)

Added: 
    

Modified: 
    lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
    lldb/test/API/commands/target/stop-hooks/TestStopHooks.py
    lldb/test/API/functionalities/step_scripted/TestStepScripted.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py b/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
index a2c9397f1a79b..ad188a32c0b97 100644
--- a/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
+++ b/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
@@ -83,7 +83,7 @@ def do_test_auto_continue(self, return_true):
           command = "target stop-hook add -G 1 -P stop_hook.stop_handler -k increment -v 5 -n step_out_of_me"
             
         self.interp.HandleCommand(command, result)
-        self.assertTrue(result.Succeeded, "Set the target stop hook")
+        self.assertTrue(result.Succeeded(), "Set the target stop hook")
 
         # First run to main.  If we go straight to the first stop hook hit,
         # run_to_source_breakpoint will fail because we aren't at original breakpoint
@@ -131,7 +131,7 @@ def stop_hooks_scripted(self, g_var_value, specifier = None):
             command += specifier
         
         self.interp.HandleCommand(command, result)
-        self.assertTrue(result.Succeeded, "Set the target stop hook")
+        self.assertTrue(result.Succeeded(), "Set the target stop hook")
         (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
                                    "Set a breakpoint here", self.main_source_file)
         # At this point we've hit our stop hook so we should have run our expression,

diff  --git a/lldb/test/API/commands/target/stop-hooks/TestStopHooks.py b/lldb/test/API/commands/target/stop-hooks/TestStopHooks.py
index 38bb17423350b..da2781574577e 100644
--- a/lldb/test/API/commands/target/stop-hooks/TestStopHooks.py
+++ b/lldb/test/API/commands/target/stop-hooks/TestStopHooks.py
@@ -39,7 +39,7 @@ def step_out_test(self):
         interp = self.dbg.GetCommandInterpreter()
         result = lldb.SBCommandReturnObject()
         interp.HandleCommand("target stop-hook add -o 'expr g_var++'", result)
-        self.assertTrue(result.Succeeded, "Set the target stop hook")
+        self.assertTrue(result.Succeeded(), "Set the target stop hook")
         thread.StepOut()
         var = target.FindFirstGlobalVariable("g_var")
         self.assertTrue(var.IsValid())
@@ -49,7 +49,7 @@ def after_expr_test(self):
         interp = self.dbg.GetCommandInterpreter()
         result = lldb.SBCommandReturnObject()
         interp.HandleCommand("target stop-hook add -o 'expr g_var++'", result)
-        self.assertTrue(result.Succeeded, "Set the target stop hook")
+        self.assertTrue(result.Succeeded(), "Set the target stop hook")
 
         (target, process, thread, first_bkpt) = lldbutil.run_to_source_breakpoint(self,
                                    "Set a breakpoint here", self.main_source_file)

diff  --git a/lldb/test/API/functionalities/step_scripted/TestStepScripted.py b/lldb/test/API/functionalities/step_scripted/TestStepScripted.py
index 189c792edf5e9..b02c5ebfd90ca 100644
--- a/lldb/test/API/functionalities/step_scripted/TestStepScripted.py
+++ b/lldb/test/API/functionalities/step_scripted/TestStepScripted.py
@@ -148,6 +148,6 @@ def do_test_stop_others(self):
         result = lldb.SBCommandReturnObject()
 
         interp.HandleCommand("settings set target.process.run-all-threads true", result)
-        self.assertTrue(result.Succeeded, "setting run-all-threads works.")
+        self.assertTrue(result.Succeeded(), "setting run-all-threads works.")
 
         self.run_step(False, None, thread_id)


        


More information about the lldb-commits mailing list