[Lldb-commits] [PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

Fri Feb 3 05:41:30 PST 2023

lenary added a comment.

In D140999#4030131 <https://reviews.llvm.org/D140999#4030131>, @MaskRay wrote:

> I don't think it is necessary to deprecate the old header then delete it after 16.0.0 is branched.
> llvm/Support/AArch64TargetParser.h has very few open-source out-of-tree uses. Perhaps only ldc `driver/targetmachine.cpp` uses the header. So it is not worth extra expedience.
> Just deleting it in another change should be fine.
>
> Changing the include to `#include "llvm/TargetParser/AArch64TargetParser.h"` is totally fine, though.

Sorry, busy time on downstream work means I haven't got back to this.

My plan now is:

- Rebase this to not care about the modulemap patch it is based on, as that is getting no review at all, despite being pinged.
- Just start deleting the forwarding headers, as [NFC] commits, updating all the references to the new headers. We're after the 16 branch point, so I think that's been a long enough cut-over period.

At some point, people will need to fix the bazel/modulemap builds, but I've tried the latter and got no traction on patches to do so.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140999/new/

https://reviews.llvm.org/D140999