[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

tl;dr: watchpoints don't work on things like arm targets with a JTAG gdb stub that doesn't support `qWatchpointSupportInfo:` or `qHostInfo` with the `watchpoint_exceptions_received` key.

Nearly all of this patch is mechanical, and IMO the question is whether I should have stuck with `Process:GetWatchpointSupportInfo` but added some way to indicate that we cannot fetch the number of watchpoints, but we can report whether the exceptions come before/after.

Also this seems a little weak to have it encoded down in GDBRemoteCommunicationClient; it seems like something we could ask the ArchSpec about tbh.  I didn't go that far, but maybe that would be better to do while I'm here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143215/new/

https://reviews.llvm.org/D143215