[Lldb-commits] [PATCH] D143024: [lldb] Use ${CMAKE_COMMAND} -E remove instead of remove_directory

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: bulbazord.
Herald added a project: All.
JDevlieghere requested review of this revision.

We no longer need to remove a directory downstream and also contrary to my previous observations, remove_directory isn't sufficient to remove a regular file.


https://reviews.llvm.org/D143024

Files:
  lldb/cmake/modules/AddLLDB.cmake


Index: lldb/cmake/modules/AddLLDB.cmake
===================================================================
--- lldb/cmake/modules/AddLLDB.cmake
+++ lldb/cmake/modules/AddLLDB.cmake
@@ -246,10 +246,8 @@
 
   # Create a custom target to remove the copy again from LLDB.framework in the
   # build tree.
-  # Intentionally use remove_directory because the target can be a either a
-  # file or directory and using remove_directory is harmless for files.
   add_custom_target(${name}-cleanup
-    COMMAND ${CMAKE_COMMAND} -E remove_directory ${copy_dest}
+    COMMAND ${CMAKE_COMMAND} -E remove ${copy_dest}
     COMMENT "Removing ${name} from LLDB.framework")
   add_dependencies(lldb-framework-cleanup
     ${name}-cleanup)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143024.493749.patch
Type: text/x-patch
Size: 723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230131/9d238fa9/attachment.bin>