[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

Thanks for the nits, good points.



================
Comment at: lldb/source/API/SBValue.cpp:935-940
+    ProcessSP process_sp = m_opaque_sp->GetProcessSP();
+    if (!process_sp)
+      return ret_val;
+    ABISP abi_sp = process_sp->GetABI();
+    if (abi_sp)
+      return abi_sp->FixCodeAddress(ret_val);
----------------
JDevlieghere wrote:
> Nit^3: why not do the same as in `GetStrippedPointerValue` and `CreateValueObjectFromAddress`:
> 
> ```
>     if (ProcessSP process_sp = m_opaque_sp->GetProcessSP())
>       if (ABISP abi_sp = process_sp->GetABI())
>             return abi_sp->FixCodeAddress(ret_val);
> ```
This method is static so I had to duplicate the functionality here. :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142792/new/

https://reviews.llvm.org/D142792