[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

Fri Jan 27 10:20:26 PST 2023

aprantl added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:180-182
+    // The unit has a dwo_id, but this isn't a .dwo skeleton unit, so
+    // the assumption is that this is a file produced by -gmodules and
+    // that we want to index it.
----------------
clayborg wrote:
> Can we do a bit more to ensure we aren't using fission here? Are there no other differences between -gmodules and fission we can key off of? Existence of .debug_addr section for fission only?
The `.debug_addr` section only exists in DWARF 5 so the IsSkeletonUnit() check covers this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142683/new/

https://reviews.llvm.org/D142683