[Lldb-commits] [PATCH] D142662: Allow bytes-only mach-o corefile to load into lldb

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 27 09:41:04 PST 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG841b26f1d80f: Don't flag memory-only mach-o corefiles as invalid (authored by jasonmolenda).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142662/new/

https://reviews.llvm.org/D142662

Files:
  lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp


Index: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
===================================================================
--- lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
+++ lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
@@ -483,13 +483,6 @@
     return error;
   }
 
-  if (core_objfile->GetNumThreadContexts() == 0) {
-    error.SetErrorString("core file doesn't contain any LC_THREAD load "
-                         "commands, or the LC_THREAD architecture is not "
-                         "supported in this lldb");
-    return error;
-  }
-
   SetCanJIT(false);
 
   // The corefile's architecture is our best starting point.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142662.492817.patch
Type: text/x-patch
Size: 670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230127/d7c3a774/attachment-0001.bin>


More information about the lldb-commits mailing list