[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

Thu Jan 26 18:12:32 PST 2023

clayborg added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:167
   if (unit.GetDWOId()) {
     if (SymbolFileDWARFDwo *dwo_symbol_file = unit.GetDwoSymbolFile()) {
       // Type units in a dwp file are indexed separately, so we just need to
----------------
Won't this return nullptr in the fission case where the .dwo file is missing or deleted?

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:180-182
+    // The unit has a dwo_id, but this isn't a .dwo skeleton unit, so
+    // the assumption is that this is a file produced by -gmodules and
+    // that we want to index it.
----------------
Can we do a bit more to ensure we aren't using fission here? Are there no other differences between -gmodules and fission we can key off of? Existence of .debug_addr section for fission only?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142683/new/

https://reviews.llvm.org/D142683