[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

Michael Buch via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 24 06:41:19 PST 2023


Michael137 added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1533
 
+std::string
+DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE &die) {
----------------
Michael137 wrote:
> Ah the function was declared but not defined (presumably a leftover from https://reviews.llvm.org/D138834)
> 
> Can we elaborate in the function docstring how this differs from `GetTemplateParameters`?
Meant to say `GetDIEClassTemplateParams`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142413/new/

https://reviews.llvm.org/D142413



More information about the lldb-commits mailing list