[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

Mon Jan 23 21:15:33 PST 2023

xgupta added a comment.

In D142309#4075616 <https://reviews.llvm.org/D142309#4075616>, @jingham wrote:

> I don't think this code is going to compile, is it?  You took out the `if (!buffer) {` but left the RHS `}` so now the scopes are unbalanced.  I think you should just change how the shared pointer is defined - which is presumably the substance of the patch - and leave everything after as is.

Yeah, correct, I didn't notice carefully. Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142309/new/

https://reviews.llvm.org/D142309