[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 23 18:01:42 PST 2023
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I don't think this code is going to compile, is it? You took out the `if (!buffer) {` but left the RHS `}` so now the scopes are unbalanced. I think you should just change how the shared pointer is defined - which is presumably the substance of the patch - and leave everything after as is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142309/new/
https://reviews.llvm.org/D142309
More information about the lldb-commits
mailing list